Don't throw when destructuring into a var named as an import #10628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Nov 2, 2019
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #10627 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
commented
Nov 2, 2019
| } = {}); | ||
| } | ||
|
|
||
| _x.foo = (2, function () { |
There was a problem hiding this comment.
In a follow up PR, this could be left as foo since we are throwing anyway.
JLHwung
reviewed
Nov 4, 2019
| .pop(); | ||
| const programScopeIds = Object.keys(ids).filter( | ||
| localName => | ||
| scope.getBinding(localName) === path.scope.getBinding(localName), |
There was a problem hiding this comment.
nit: consider to guard with scope.hasBinding to avoid unnecessary path.scope.getBinding.
There was a problem hiding this comment.
I tried to do it and found a bug which, if fixed, would break @babel/plugin-transform-runtime <= 7.6 😢
This is what currently happens:
- The imports are analyzed
- The imports are removed -> The bindings are removed
- References to imported bindings are rewritten (this file)
i) When we are comparing the bindings, the global one isundefined
ii) If the local binding isundefined, it hasn't been redefined.
I tried to swap 2 and 3, but I still can optimize away the check for the local binding because @babel/transform-runtime doesn't register the import it injects in the scope tracker.
JLHwung
approved these changes
Nov 4, 2019
existentialism
approved these changes
Nov 4, 2019
nicolo-ribaudo
force-pushed
the
import-shadowed-destructuring-assign
branch
2 times, most recently
from
14a6afa
to
65c0f1f
Compare
This was referenced Nov 28, 2019
This was referenced Dec 5, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.