Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates documentation of the findParent and find methods #10479

Merged
merged 1 commit into from Sep 22, 2019
Merged

Updates documentation of the findParent and find methods #10479

merged 1 commit into from Sep 22, 2019

Conversation

TomerAberbach
Copy link
Contributor

@TomerAberbach TomerAberbach commented Sep 22, 2019 •
edited

Q                       A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No new tests
Documentation PR Link
Any Dependency Changes? No
License MIT

Updates the documentation of the findParent and find methods so that they are consistent with each other and so that they mention when they return null.

@TomerAberbach
docs: updates docs of findParent and find
fe6981a 
Makes the documentation of `findParent` and `find` consistent and documents their `null` cases.
@nicolo-ribaudo
Copy link
Member

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 962015f into babel:master Sep 22, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomerAberbach @nicolo-ribaudo