New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "validateLogs" for preset-env's debug fixtures #10401
Merged
nicolo-ribaudo
merged 2 commits into
babel:master
from
nicolo-ribaudo:preset-env-debug-fixtures-no-cp
Sep 6, 2019
Merged
Use "validateLogs" for preset-env's debug fixtures #10401
nicolo-ribaudo
merged 2 commits into
babel:master
from
nicolo-ribaudo:preset-env-debug-fixtures-no-cp
Sep 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
area: tests
PR: Internal 🏠
A type of pull request used for our changelog categories
labels
Sep 6, 2019
existentialism
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, been on the list from when we first wrote preset-env :)
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11479/ |
JLHwung
approved these changes
Sep 6, 2019
This was referenced Sep 15, 2019
This was referenced Oct 2, 2019
This was referenced Nov 28, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: tests
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Internal 🏠
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes preset-env's
debug-fixtures
use the new functionality introduced in #10326This has two main advantages:
time yarn jest preset-env
before this PR:time yarn jest preset-env
after this PR:time yarn jest
before this PR:time yarn jest
after this PR:NOTES:
debug-fixtures
contained two input files. I split them in two different fixturesSuccessfully compiled 1 file with Babel.
disappeared fromstdout
, because it wasn't printed bypreset-env
but by@babel/cli
options.json
orstdout.txt
files are reported as "new" or "deleted" by git. It's just because of the fixtures I duplicated, or because git doesn't properly track renames of small files with many updates.