Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pipeline nodes to ast.spec #10214

Merged
merged 1 commit into from Jul 13, 2019
Merged

Add Pipeline nodes to ast.spec #10214

merged 1 commit into from Jul 13, 2019

Conversation

mAAdhaTTah
Copy link
Contributor

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? N/A
Major: Breaking Change? N/A
Minor: New Feature? N/A
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Add the missing types in ast/spec.md, addressing the comment here.

nicolo-ribaudo
nicolo-ribaudo reviewed Jul 13, 2019
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a note that f# uses simple BinaryExpressions?

@mAAdhaTTah
Copy link
Contributor Author

@nicolo-ribaudo Done!

@thiagoarrais
Copy link
Contributor

Nice work!

@nicolo-ribaudo nicolo-ribaudo merged commit 7f47cb6 into babel:master Jul 13, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thiagoarrais thiagoarrais thiagoarrais approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mAAdhaTTah @thiagoarrais @nicolo-ribaudo