New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround #10179 in proposal-object-rest-spread #10200
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
i: regression
Spec: Object Rest/Spread
labels
Jul 11, 2019
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11109/ |
danez
approved these changes
Jul 13, 2019
thiagoarrais
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix confirmed locally.
Release tomorrow! |
AdamRamberg
pushed a commit
to AdamRamberg/babel
that referenced
this pull request
Jul 17, 2019
This was referenced Sep 15, 2019
This was referenced Sep 23, 2019
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
i: regression
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Object Rest/Spread
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real cause of this bug is in
@babel/core
(#10187), but even if we fixed it new versions ofplugin-proposal-object-rest-spread
wouldn't work with older versions of@babel/core
and@babel/helpers
.This bug also needs to be fixed in
@babel/core
anyway, otherwise it will happen again.I couldn't figure out how to add a test for this bug; I tested it manually with a
package.json
like this (it requiresyarn
):Input
Output before the fix
Output after the fix
Note that in the fixed output the injected helper is called
_objectSpread2
only because Babel is trolling* us, that is the_objectSpread
helper present in <7.5.0.*trolling = In the "try" block it genertes an
_objectSpread
UUID which is then discarted, so it must create_objectSpread2
the second time.