chore: update babel-preset-stage (0,1,2,3 readme files) #10111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ], | ||
| presets: [ | ||
| // ... | ||
| ], | ||
| }; | ||
| }; | ||
| ``` | ||
|
|
||
| **NOTE: Compatibility with @babel/plugin-proposal-class-properties** |
There was a problem hiding this comment.
Suggested change
| **NOTE: Compatibility with @babel/plugin-proposal-class-properties** | |
| **NOTE: Compatibility between `@babel/plugin-proposal-class-properties` and `@babel/plugin-proposal-decorators`** |
There was a problem hiding this comment.
@nicolo-ribaudo I will apply these changes for all, right?
|
|
||
| When using the `legacy: true` mode, `@babel/plugin-proposal-class-properties` must be used in `loose: true` mode to support the @babel/plugin-proposal-decorators. | ||
|
|
||
| If are not using `@babel/plugin-proposal-decorators`, `loose` mode is not needed at all. |
There was a problem hiding this comment.
I'd remove "at all", since there are many other valid reasons.
| **NOTE: Compatibility with @babel/plugin-proposal-class-properties** | ||
| If you are including your plugins manually and using `@babel/plugin-proposal-class-properties`, make sure that `@babel/plugin-proposal-decorators` comes before `@babel/plugin-proposal-class-properties`. | ||
|
|
||
| When using the `legacy: true` mode, `@babel/plugin-proposal-class-properties` must be used in `loose: true` mode to support the @babel/plugin-proposal-decorators. |
There was a problem hiding this comment.
Suggested change
| When using the `legacy: true` mode, `@babel/plugin-proposal-class-properties` must be used in `loose: true` mode to support the @babel/plugin-proposal-decorators. | |
| When using the `legacy: true` option of `@babel/plugin-proposal-decorators`, `@babel/plugin-proposal-class-properties` must be used in `loose: true` mode. |
nicolo-ribaudo
approved these changes
Jun 19, 2019
nicolo-ribaudo
added
the
PR: Docs 📝
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow by #8427 issue