From f643f17861fb0f990f1d523dc460feb282964f14 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Mon, 7 Nov 2022 12:08:23 -0500 Subject: [PATCH] disable side_effects compress option for helpers --- packages/babel-helpers/scripts/generate-helpers.js | 8 ++++++-- packages/babel-helpers/src/helpers-generated.ts | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/babel-helpers/scripts/generate-helpers.js b/packages/babel-helpers/scripts/generate-helpers.js index e0b37019320f..2bf301f4a773 100644 --- a/packages/babel-helpers/scripts/generate-helpers.js +++ b/packages/babel-helpers/scripts/generate-helpers.js @@ -47,8 +47,12 @@ export default Object.freeze({ const source = await minify(fileContents, { mangle: false, - // The _typeof helper has a custom directive that we must keep - compress: { directives: false }, + compress: { + // The _typeof helper has a custom directive that we must keep + directives: false, + // The _checkInRHS helper has `0 in value` which does have side effects + side_effects: false, + }, }); output += `\ diff --git a/packages/babel-helpers/src/helpers-generated.ts b/packages/babel-helpers/src/helpers-generated.ts index e7eabc002073..c9ca232fbde2 100644 --- a/packages/babel-helpers/src/helpers-generated.ts +++ b/packages/babel-helpers/src/helpers-generated.ts @@ -43,7 +43,7 @@ export default Object.freeze({ ), checkInRHS: helper( "7.20.1", - "export default function _checkInRHS(value){return value}", + "export default function _checkInRHS(value){return 0 in value,value}", ), jsx: helper( "7.0.0-beta.0",