From 7b2bdaecd7e7396a720e165989d5cb3e752d23d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Wed, 17 Nov 2021 00:13:21 +0100 Subject: [PATCH] Fix tests on Node.js 12 --- .../babel-eslint-tests/test/helpers/verifyAndAssertMessages.js | 2 +- packages/babel-cli/test/index.js | 2 +- packages/babel-core/test/config-chain.js | 2 +- packages/babel-parser/test/helpers/runFixtureTests.js | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js b/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js index 6829c73bbbd6..4fab9a573330 100644 --- a/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js +++ b/eslint/babel-eslint-tests/test/helpers/verifyAndAssertMessages.js @@ -31,7 +31,7 @@ export default function verifyAndAssertMessages( "../../../babel-eslint-shared-fixtures/config/babel.config.js", ), }, - ...overrideConfig?.parserOptions, + ...(overrideConfig && overrideConfig.parserOptions), }, }); diff --git a/packages/babel-cli/test/index.js b/packages/babel-cli/test/index.js index 85395b30a169..2de08e866d00 100644 --- a/packages/babel-cli/test/index.js +++ b/packages/babel-cli/test/index.js @@ -123,7 +123,7 @@ const assertTest = function (stdout, stderr, opts, cwd) { const expected = opts.outFiles[filename]; const actual = actualFiles[filename]; - expect(actual).toBe(expected ?? ""); + expect(actual).toBe(expected || ""); } } catch (e) { e.message += "\n at " + filename; diff --git a/packages/babel-core/test/config-chain.js b/packages/babel-core/test/config-chain.js index e8a7d967062a..01961fa7e110 100644 --- a/packages/babel-core/test/config-chain.js +++ b/packages/babel-core/test/config-chain.js @@ -14,7 +14,7 @@ import { isMJS, loadOptionsAsync, skipUnsupportedESM } from "./helpers/esm.js"; // TODO: In Babel 8, we can directly uses fs.promises which is supported by // node 8+ const pfs = - fs.promises ?? + fs.promises || new Proxy(fs, { get(target, name) { if (name === "copyFile") { diff --git a/packages/babel-parser/test/helpers/runFixtureTests.js b/packages/babel-parser/test/helpers/runFixtureTests.js index 0aaf0858d6b6..7388a01d836c 100644 --- a/packages/babel-parser/test/helpers/runFixtureTests.js +++ b/packages/babel-parser/test/helpers/runFixtureTests.js @@ -218,7 +218,7 @@ function runTest(test, parseFunction, compareErrorsOnly = false) { return save(test, ast); } - if (ast.errors?.length) { + if (ast.errors && ast.errors.length) { throw new Error( `Expected non-recoverable error message: ${ opts.throws