From 752fc2bf1f2c47e5cac04db26807fe0fed31cabf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Thu, 29 Apr 2021 20:58:51 -0400 Subject: [PATCH] nit: ensure end is assigned after start --- .../attachComment-false.bench.mjs | 2 +- packages/babel-parser/src/parser/node.js | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/benchmark/babel-parser/many-leading-trailing-comments/attachComment-false.bench.mjs b/benchmark/babel-parser/many-leading-trailing-comments/attachComment-false.bench.mjs index f0f6eeaeb0a2..3866f375362f 100644 --- a/benchmark/babel-parser/many-leading-trailing-comments/attachComment-false.bench.mjs +++ b/benchmark/babel-parser/many-leading-trailing-comments/attachComment-false.bench.mjs @@ -1,5 +1,5 @@ import Benchmark from "benchmark"; -import baseline from "../../lib/index-v1.js"; +import baseline from "@babel-baseline/parser"; import current from "../../lib/index.js"; import { report } from "../util.mjs"; diff --git a/packages/babel-parser/src/parser/node.js b/packages/babel-parser/src/parser/node.js index b3069ea9f7dd..1d8a08b90a0d 100644 --- a/packages/babel-parser/src/parser/node.js +++ b/packages/babel-parser/src/parser/node.js @@ -10,6 +10,7 @@ import type { Comment, Node as NodeType, NodeBase } from "../types"; class Node implements NodeBase { constructor(parser: Parser, pos: number, loc: Position) { this.start = pos; + this.end = 0; this.loc = new SourceLocation(loc); if (parser?.options.ranges) this.range = [pos, 0]; if (parser?.filename) this.loc.filename = parser.filename; @@ -17,13 +18,13 @@ class Node implements NodeBase { type: string = ""; declare start: number; - end: number = 0; - loc: SourceLocation; + declare end: number; + declare loc: SourceLocation; declare range: [number, number]; declare leadingComments: Array; declare trailingComments: Array; declare innerComments: Array; - extra: { [key: string]: any }; + declare extra: { [key: string]: any }; } const NodePrototype = Node.prototype;