diff --git a/packages/babel-generator/src/generators/flow.ts b/packages/babel-generator/src/generators/flow.ts index b4373bffe3fe..3668d07c0c27 100644 --- a/packages/babel-generator/src/generators/flow.ts +++ b/packages/babel-generator/src/generators/flow.ts @@ -745,3 +745,16 @@ export function IndexedAccessType(this: Printer, node: t.IndexedAccessType) { this.print(node.indexType, node); this.token("]"); } + +export function OptionalIndexedAccessType( + this: Printer, + node: t.OptionalIndexedAccessType, +) { + this.print(node.objectType, node); + if (node.optional) { + this.token("?."); + } + this.token("["); + this.print(node.indexType, node); + this.token("]"); +} diff --git a/packages/babel-generator/src/node/parentheses.ts b/packages/babel-generator/src/node/parentheses.ts index 867419aa467d..3f7019a82e3d 100644 --- a/packages/babel-generator/src/node/parentheses.ts +++ b/packages/babel-generator/src/node/parentheses.ts @@ -135,6 +135,10 @@ export function UnionTypeAnnotation(node: any, parent: any): boolean { export { UnionTypeAnnotation as IntersectionTypeAnnotation }; +export function OptionalIndexedAccessType(node: any, parent: any): boolean { + return t.isIndexedAccessType(parent, { objectType: node }); +} + export function TSAsExpression() { return true; } diff --git a/packages/babel-generator/test/fixtures/flow/optional-indexed-access-types/input.js b/packages/babel-generator/test/fixtures/flow/optional-indexed-access-types/input.js new file mode 100644 index 000000000000..797020e7b1de --- /dev/null +++ b/packages/babel-generator/test/fixtures/flow/optional-indexed-access-types/input.js @@ -0,0 +1,9 @@ +type A = Obj?.['a']; + +type B = Array?.[number]; + +type C = Obj?.['bar']['baz']; + +type D = (Obj?.['bar'])['baz']; + +type E = Obj?.['bar'][]; diff --git a/packages/babel-generator/test/fixtures/flow/optional-indexed-access-types/output.js b/packages/babel-generator/test/fixtures/flow/optional-indexed-access-types/output.js new file mode 100644 index 000000000000..19cfff300aa8 --- /dev/null +++ b/packages/babel-generator/test/fixtures/flow/optional-indexed-access-types/output.js @@ -0,0 +1,5 @@ +type A = Obj?.['a']; +type B = Array?.[number]; +type C = Obj?.['bar']['baz']; +type D = (Obj?.['bar'])['baz']; +type E = Obj?.['bar'][]; diff --git a/packages/babel-parser/src/plugins/flow/index.js b/packages/babel-parser/src/plugins/flow/index.js index 256590452db2..a237acffa5bb 100644 --- a/packages/babel-parser/src/plugins/flow/index.js +++ b/packages/babel-parser/src/plugins/flow/index.js @@ -1619,13 +1619,19 @@ export default (superClass: Class): Class => } flowParsePostfixType(): N.FlowTypeAnnotation { - const startPos = this.state.start, - startLoc = this.state.startLoc; + const startPos = this.state.start; + const startLoc = this.state.startLoc; let type = this.flowParsePrimaryType(); - while (this.match(tt.bracketL) && !this.canInsertSemicolon()) { + let seenOptionalIndexedAccess = false; + while ( + (this.match(tt.bracketL) || this.match(tt.questionDot)) && + !this.canInsertSemicolon() + ) { const node = this.startNodeAt(startPos, startLoc); + const optional = this.eat(tt.questionDot); + seenOptionalIndexedAccess = seenOptionalIndexedAccess || optional; this.expect(tt.bracketL); - if (this.match(tt.bracketR)) { + if (!optional && this.match(tt.bracketR)) { node.elementType = type; this.next(); // eat `]` type = this.finishNode(node, "ArrayTypeAnnotation"); @@ -1633,10 +1639,18 @@ export default (superClass: Class): Class => node.objectType = type; node.indexType = this.flowParseType(); this.expect(tt.bracketR); - type = this.finishNode( - node, - "IndexedAccessType", - ); + if (seenOptionalIndexedAccess) { + node.optional = optional; + type = this.finishNode( + node, + "OptionalIndexedAccessType", + ); + } else { + type = this.finishNode( + node, + "IndexedAccessType", + ); + } } } return type; @@ -2216,6 +2230,9 @@ export default (superClass: Class): Class => ) { return this.finishOp(tt.relational, 1); } else if (this.state.inType && code === charCodes.questionMark) { + if (next === charCodes.dot) { + return this.finishOp(tt.questionDot, 2); + } // allow double nullable types in Flow: ??string return this.finishOp(tt.question, 1); } else if (isIteratorStart(code, next)) { diff --git a/packages/babel-parser/src/types.js b/packages/babel-parser/src/types.js index c0c996389981..fa716fd62ff2 100644 --- a/packages/babel-parser/src/types.js +++ b/packages/babel-parser/src/types.js @@ -1058,6 +1058,13 @@ export type FlowIndexedAccessType = Node & { indexType: FlowType, }; +export type FlowOptionalIndexedAccessType = Node & { + type: "OptionalIndexedAccessType", + objectType: FlowType, + indexType: FlowType, + optional: boolean, +}; + // ESTree export type EstreeProperty = NodeBase & { diff --git a/packages/babel-parser/test/fixtures/flow/indexed-access-types/1/input.js b/packages/babel-parser/test/fixtures/flow/indexed-access-types/base/input.js similarity index 100% rename from packages/babel-parser/test/fixtures/flow/indexed-access-types/1/input.js rename to packages/babel-parser/test/fixtures/flow/indexed-access-types/base/input.js diff --git a/packages/babel-parser/test/fixtures/flow/indexed-access-types/1/output.json b/packages/babel-parser/test/fixtures/flow/indexed-access-types/base/output.json similarity index 100% rename from packages/babel-parser/test/fixtures/flow/indexed-access-types/1/output.json rename to packages/babel-parser/test/fixtures/flow/indexed-access-types/base/output.json diff --git a/packages/babel-parser/test/fixtures/flow/indexed-access-types/optional/input.js b/packages/babel-parser/test/fixtures/flow/indexed-access-types/optional/input.js new file mode 100644 index 000000000000..f184ba3b1982 --- /dev/null +++ b/packages/babel-parser/test/fixtures/flow/indexed-access-types/optional/input.js @@ -0,0 +1,7 @@ +type A = Obj?.['a']; + +type B = Obj['a']?.['b']; + +type C = Obj?.['a']['b']; + +type D = Obj?.['a']?.['b']; diff --git a/packages/babel-parser/test/fixtures/flow/indexed-access-types/optional/output.json b/packages/babel-parser/test/fixtures/flow/indexed-access-types/optional/output.json new file mode 100644 index 000000000000..1ae1dfa76178 --- /dev/null +++ b/packages/babel-parser/test/fixtures/flow/indexed-access-types/optional/output.json @@ -0,0 +1,190 @@ +{ + "type": "File", + "start":0,"end":103,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":27}}, + "program": { + "type": "Program", + "start":0,"end":103,"loc":{"start":{"line":1,"column":0},"end":{"line":7,"column":27}}, + "sourceType": "module", + "interpreter": null, + "body": [ + { + "type": "TypeAlias", + "start":0,"end":20,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":20}}, + "id": { + "type": "Identifier", + "start":5,"end":6,"loc":{"start":{"line":1,"column":5},"end":{"line":1,"column":6},"identifierName":"A"}, + "name": "A" + }, + "typeParameters": null, + "right": { + "type": "OptionalIndexedAccessType", + "start":9,"end":19,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":19}}, + "objectType": { + "type": "GenericTypeAnnotation", + "start":9,"end":12,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":12}}, + "typeParameters": null, + "id": { + "type": "Identifier", + "start":9,"end":12,"loc":{"start":{"line":1,"column":9},"end":{"line":1,"column":12},"identifierName":"Obj"}, + "name": "Obj" + } + }, + "indexType": { + "type": "StringLiteralTypeAnnotation", + "start":15,"end":18,"loc":{"start":{"line":1,"column":15},"end":{"line":1,"column":18}}, + "extra": { + "rawValue": "a", + "raw": "'a'" + }, + "value": "a" + }, + "optional": true + } + }, + { + "type": "TypeAlias", + "start":22,"end":47,"loc":{"start":{"line":3,"column":0},"end":{"line":3,"column":25}}, + "id": { + "type": "Identifier", + "start":27,"end":28,"loc":{"start":{"line":3,"column":5},"end":{"line":3,"column":6},"identifierName":"B"}, + "name": "B" + }, + "typeParameters": null, + "right": { + "type": "OptionalIndexedAccessType", + "start":31,"end":46,"loc":{"start":{"line":3,"column":9},"end":{"line":3,"column":24}}, + "objectType": { + "type": "IndexedAccessType", + "start":31,"end":39,"loc":{"start":{"line":3,"column":9},"end":{"line":3,"column":17}}, + "objectType": { + "type": "GenericTypeAnnotation", + "start":31,"end":34,"loc":{"start":{"line":3,"column":9},"end":{"line":3,"column":12}}, + "typeParameters": null, + "id": { + "type": "Identifier", + "start":31,"end":34,"loc":{"start":{"line":3,"column":9},"end":{"line":3,"column":12},"identifierName":"Obj"}, + "name": "Obj" + } + }, + "indexType": { + "type": "StringLiteralTypeAnnotation", + "start":35,"end":38,"loc":{"start":{"line":3,"column":13},"end":{"line":3,"column":16}}, + "extra": { + "rawValue": "a", + "raw": "'a'" + }, + "value": "a" + } + }, + "indexType": { + "type": "StringLiteralTypeAnnotation", + "start":42,"end":45,"loc":{"start":{"line":3,"column":20},"end":{"line":3,"column":23}}, + "extra": { + "rawValue": "b", + "raw": "'b'" + }, + "value": "b" + }, + "optional": true + } + }, + { + "type": "TypeAlias", + "start":49,"end":74,"loc":{"start":{"line":5,"column":0},"end":{"line":5,"column":25}}, + "id": { + "type": "Identifier", + "start":54,"end":55,"loc":{"start":{"line":5,"column":5},"end":{"line":5,"column":6},"identifierName":"C"}, + "name": "C" + }, + "typeParameters": null, + "right": { + "type": "OptionalIndexedAccessType", + "start":58,"end":73,"loc":{"start":{"line":5,"column":9},"end":{"line":5,"column":24}}, + "objectType": { + "type": "OptionalIndexedAccessType", + "start":58,"end":68,"loc":{"start":{"line":5,"column":9},"end":{"line":5,"column":19}}, + "objectType": { + "type": "GenericTypeAnnotation", + "start":58,"end":61,"loc":{"start":{"line":5,"column":9},"end":{"line":5,"column":12}}, + "typeParameters": null, + "id": { + "type": "Identifier", + "start":58,"end":61,"loc":{"start":{"line":5,"column":9},"end":{"line":5,"column":12},"identifierName":"Obj"}, + "name": "Obj" + } + }, + "indexType": { + "type": "StringLiteralTypeAnnotation", + "start":64,"end":67,"loc":{"start":{"line":5,"column":15},"end":{"line":5,"column":18}}, + "extra": { + "rawValue": "a", + "raw": "'a'" + }, + "value": "a" + }, + "optional": true + }, + "indexType": { + "type": "StringLiteralTypeAnnotation", + "start":69,"end":72,"loc":{"start":{"line":5,"column":20},"end":{"line":5,"column":23}}, + "extra": { + "rawValue": "b", + "raw": "'b'" + }, + "value": "b" + }, + "optional": false + } + }, + { + "type": "TypeAlias", + "start":76,"end":103,"loc":{"start":{"line":7,"column":0},"end":{"line":7,"column":27}}, + "id": { + "type": "Identifier", + "start":81,"end":82,"loc":{"start":{"line":7,"column":5},"end":{"line":7,"column":6},"identifierName":"D"}, + "name": "D" + }, + "typeParameters": null, + "right": { + "type": "OptionalIndexedAccessType", + "start":85,"end":102,"loc":{"start":{"line":7,"column":9},"end":{"line":7,"column":26}}, + "objectType": { + "type": "OptionalIndexedAccessType", + "start":85,"end":95,"loc":{"start":{"line":7,"column":9},"end":{"line":7,"column":19}}, + "objectType": { + "type": "GenericTypeAnnotation", + "start":85,"end":88,"loc":{"start":{"line":7,"column":9},"end":{"line":7,"column":12}}, + "typeParameters": null, + "id": { + "type": "Identifier", + "start":85,"end":88,"loc":{"start":{"line":7,"column":9},"end":{"line":7,"column":12},"identifierName":"Obj"}, + "name": "Obj" + } + }, + "indexType": { + "type": "StringLiteralTypeAnnotation", + "start":91,"end":94,"loc":{"start":{"line":7,"column":15},"end":{"line":7,"column":18}}, + "extra": { + "rawValue": "a", + "raw": "'a'" + }, + "value": "a" + }, + "optional": true + }, + "indexType": { + "type": "StringLiteralTypeAnnotation", + "start":98,"end":101,"loc":{"start":{"line":7,"column":22},"end":{"line":7,"column":25}}, + "extra": { + "rawValue": "b", + "raw": "'b'" + }, + "value": "b" + }, + "optional": true + } + } + ], + "directives": [] + } +} \ No newline at end of file diff --git a/packages/babel-traverse/src/path/generated/asserts.ts b/packages/babel-traverse/src/path/generated/asserts.ts index ac9c5bd4895e..bd66907898ad 100755 --- a/packages/babel-traverse/src/path/generated/asserts.ts +++ b/packages/babel-traverse/src/path/generated/asserts.ts @@ -390,6 +390,9 @@ export interface NodePathAssetions { assertOptionalCallExpression( opts?: object, ): asserts this is NodePath; + assertOptionalIndexedAccessType( + opts?: object, + ): asserts this is NodePath; assertOptionalMemberExpression( opts?: object, ): asserts this is NodePath; diff --git a/packages/babel-traverse/src/path/generated/validators.ts b/packages/babel-traverse/src/path/generated/validators.ts index 271f5e5595fa..75c8badee01a 100755 --- a/packages/babel-traverse/src/path/generated/validators.ts +++ b/packages/babel-traverse/src/path/generated/validators.ts @@ -234,6 +234,9 @@ export interface NodePathValidators { isOptionalCallExpression( opts?: object, ): this is NodePath; + isOptionalIndexedAccessType( + opts?: object, + ): this is NodePath; isOptionalMemberExpression( opts?: object, ): this is NodePath; diff --git a/packages/babel-types/src/asserts/generated/index.ts b/packages/babel-types/src/asserts/generated/index.ts index ea97792a1e1c..82a09be6b0eb 100755 --- a/packages/babel-types/src/asserts/generated/index.ts +++ b/packages/babel-types/src/asserts/generated/index.ts @@ -884,6 +884,12 @@ export function assertIndexedAccessType( ): asserts node is t.IndexedAccessType { assert("IndexedAccessType", node, opts); } +export function assertOptionalIndexedAccessType( + node: object | null | undefined, + opts?: object | null, +): asserts node is t.OptionalIndexedAccessType { + assert("OptionalIndexedAccessType", node, opts); +} export function assertJSXAttribute( node: object | null | undefined, opts?: object | null, diff --git a/packages/babel-types/src/ast-types/generated/index.ts b/packages/babel-types/src/ast-types/generated/index.ts index a5f105c87cda..3476f1c2a097 100755 --- a/packages/babel-types/src/ast-types/generated/index.ts +++ b/packages/babel-types/src/ast-types/generated/index.ts @@ -208,6 +208,7 @@ export type Node = | ObjectTypeSpreadProperty | OpaqueType | OptionalCallExpression + | OptionalIndexedAccessType | OptionalMemberExpression | ParenthesizedExpression | Pattern @@ -1395,6 +1396,13 @@ export interface IndexedAccessType extends BaseNode { indexType: FlowType; } +export interface OptionalIndexedAccessType extends BaseNode { + type: "OptionalIndexedAccessType"; + objectType: FlowType; + indexType: FlowType; + optional: boolean; +} + export interface JSXAttribute extends BaseNode { type: "JSXAttribute"; name: JSXIdentifier | JSXNamespacedName; @@ -2361,7 +2369,9 @@ export type Flow = | TypeParameterInstantiation | UnionTypeAnnotation | Variance - | VoidTypeAnnotation; + | VoidTypeAnnotation + | IndexedAccessType + | OptionalIndexedAccessType; export type FlowType = | AnyTypeAnnotation | ArrayTypeAnnotation @@ -2386,7 +2396,9 @@ export type FlowType = | TupleTypeAnnotation | TypeofTypeAnnotation | UnionTypeAnnotation - | VoidTypeAnnotation; + | VoidTypeAnnotation + | IndexedAccessType + | OptionalIndexedAccessType; export type FlowBaseAnnotation = | AnyTypeAnnotation | BooleanTypeAnnotation diff --git a/packages/babel-types/src/builders/generated/index.ts b/packages/babel-types/src/builders/generated/index.ts index a0adb832b1cc..68c33b7205ab 100755 --- a/packages/babel-types/src/builders/generated/index.ts +++ b/packages/babel-types/src/builders/generated/index.ts @@ -860,6 +860,12 @@ export function indexedAccessType( ): t.IndexedAccessType { return builder("IndexedAccessType", ...arguments); } +export function optionalIndexedAccessType( + objectType: t.FlowType, + indexType: t.FlowType, +): t.OptionalIndexedAccessType { + return builder("OptionalIndexedAccessType", ...arguments); +} export function jsxAttribute( name: t.JSXIdentifier | t.JSXNamespacedName, value?: diff --git a/packages/babel-types/src/builders/generated/uppercase.js b/packages/babel-types/src/builders/generated/uppercase.js index 464b86423ce3..11ac2fb74514 100755 --- a/packages/babel-types/src/builders/generated/uppercase.js +++ b/packages/babel-types/src/builders/generated/uppercase.js @@ -154,6 +154,7 @@ export { enumStringMember as EnumStringMember, enumDefaultedMember as EnumDefaultedMember, indexedAccessType as IndexedAccessType, + optionalIndexedAccessType as OptionalIndexedAccessType, jsxAttribute as JSXAttribute, jsxClosingElement as JSXClosingElement, jsxElement as JSXElement, diff --git a/packages/babel-types/src/definitions/flow.ts b/packages/babel-types/src/definitions/flow.ts index 91ce3405a811..4c73176ef0fa 100644 --- a/packages/babel-types/src/definitions/flow.ts +++ b/packages/babel-types/src/definitions/flow.ts @@ -562,8 +562,19 @@ defineType("EnumDefaultedMember", { defineType("IndexedAccessType", { visitor: ["objectType", "indexType"], + aliases: ["Flow", "FlowType"], + fields: { + objectType: validateType("FlowType"), + indexType: validateType("FlowType"), + }, +}); + +defineType("OptionalIndexedAccessType", { + visitor: ["objectType", "indexType"], + aliases: ["Flow", "FlowType"], fields: { objectType: validateType("FlowType"), indexType: validateType("FlowType"), + optional: validate(assertValueType("boolean")), }, }); diff --git a/packages/babel-types/src/validators/generated/index.ts b/packages/babel-types/src/validators/generated/index.ts index e86131e2182b..00a7f76c43fa 100755 --- a/packages/babel-types/src/validators/generated/index.ts +++ b/packages/babel-types/src/validators/generated/index.ts @@ -2470,6 +2470,23 @@ export function isIndexedAccessType( return false; } +export function isOptionalIndexedAccessType( + node: object | null | undefined, + opts?: object | null, +): node is t.OptionalIndexedAccessType { + if (!node) return false; + + const nodeType = (node as t.Node).type; + if (nodeType === "OptionalIndexedAccessType") { + if (typeof opts === "undefined") { + return true; + } else { + return shallowEqual(node, opts); + } + } + + return false; +} export function isJSXAttribute( node: object | null | undefined, opts?: object | null, @@ -5101,7 +5118,9 @@ export function isFlow( "TypeParameterInstantiation" === nodeType || "UnionTypeAnnotation" === nodeType || "Variance" === nodeType || - "VoidTypeAnnotation" === nodeType + "VoidTypeAnnotation" === nodeType || + "IndexedAccessType" === nodeType || + "OptionalIndexedAccessType" === nodeType ) { if (typeof opts === "undefined") { return true; @@ -5143,7 +5162,9 @@ export function isFlowType( "TupleTypeAnnotation" === nodeType || "TypeofTypeAnnotation" === nodeType || "UnionTypeAnnotation" === nodeType || - "VoidTypeAnnotation" === nodeType + "VoidTypeAnnotation" === nodeType || + "IndexedAccessType" === nodeType || + "OptionalIndexedAccessType" === nodeType ) { if (typeof opts === "undefined") { return true;