From 1c748d36fab3b91e7d98b5f83e8d53ed8158e1bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= Date: Tue, 11 Jan 2022 23:02:41 +0100 Subject: [PATCH] Remove unnecessary Set cast in tests --- .../babel-core/test/external-dependencies.js | 21 ++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/packages/babel-core/test/external-dependencies.js b/packages/babel-core/test/external-dependencies.js index 4259d4353ef7..fe041e054484 100644 --- a/packages/babel-core/test/external-dependencies.js +++ b/packages/babel-core/test/external-dependencies.js @@ -30,7 +30,18 @@ describe("externalDependencies", () => { plugins: [makePlugin("./foo")], }); - expect(new Set(externalDependencies)).toEqual(new Set(["./foo"])); + expect(externalDependencies).toEqual(new Set(["./foo"])); + }); + + it("returns a fresh set", () => { + const options = { + plugins: [makePlugin("./foo")], + }; + const res1 = transform("", options); + const res2 = transform("", options); + + expect(res1.externalDependencies).toEqual(res2.externalDependencies); + expect(res1.externalDependencies).not.toBe(res2.externalDependencies); }); it("can be set multiple times by the same plugin", () => { @@ -45,7 +56,7 @@ describe("externalDependencies", () => { ], }); - expect(new Set(externalDependencies)).toEqual(new Set(["./foo", "./bar"])); + expect(externalDependencies).toEqual(new Set(["./foo", "./bar"])); }); it("can be set by presets", () => { @@ -53,7 +64,7 @@ describe("externalDependencies", () => { presets: [makePreset("./foo")], }); - expect(new Set(externalDependencies)).toEqual(new Set(["./foo"])); + expect(externalDependencies).toEqual(new Set(["./foo"])); }); it("can be set multiple times by the same preset", () => { @@ -68,7 +79,7 @@ describe("externalDependencies", () => { ], }); - expect(new Set(externalDependencies)).toEqual(new Set(["./foo", "./bar"])); + expect(externalDependencies).toEqual(new Set(["./foo", "./bar"])); }); it("can be set by multiple plugins and presets", () => { @@ -82,7 +93,7 @@ describe("externalDependencies", () => { ], }); - expect(new Set(externalDependencies)).toEqual( + expect(externalDependencies).toEqual( new Set([ "./plugin1", "./plugin2",