Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: Tools that use @babel/core as a dep #20

Closed
5 of 8 tasks
hzoo opened this issue Feb 21, 2018 · 2 comments
Closed
5 of 8 tasks

Tracking: Tools that use @babel/core as a dep #20

hzoo opened this issue Feb 21, 2018 · 2 comments

Comments

@hzoo
Copy link
Member

hzoo commented Feb 21, 2018

Writing down if tools are converted/what we need to do. Tracking date added to the list too.

Apps

@motss
Copy link

motss commented Apr 5, 2018

How about ts-jest?

@FND
Copy link

FND commented Apr 5, 2018

FWIW, I just upgraded faucet-pipeline (faucet-pipeline/faucet-pipeline-js#45), which turned out to be pleasantly straightforward once I'd figured out what needed to be done.

Just in case it helps improve the path for others, allow me to elaborate on my journey:

I didn't know babel-upgrade existed, only learned about it via Henry's tweet. This brought me here - which was a little disorienting at first, as neither the issue description nor the README clearly state what babel-upgrade actually does. (Not a criticism, just an observation from someone who isn't tied into the community too closely.)

The usage instructions recommend using npx babel-upgrade, which I thought meant I had to npm install babel-upgrade first (apparently npx does that on the fly; TIL!). The final step was inferring that babel-upgrade modifies the respective package.json, upgrading dependencies - for Babel's own packages as well as packages from the greater ecosystem (in my case: rollup-plugin-babel).

After that, everything was pretty simple: updating dependencies to their latest version (babel-upgrade's transformations were a little outdated), running npm install (manually, mostly because I hadn't grokked babel-upgrade's role in the first place) and updating our tests (we're intentionally keeping a close eye on transpilation output, just to be safe).

The only trouble was figuring out the necessary Rollup adjustments (particularly WRT babel-plugin-external-helpers), but that wasn't a big deal either.

Anyway, looks like we're all set now - thanks for all your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants