Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema validation #822

Merged
merged 2 commits into from Feb 21, 2020
Merged

Add schema validation #822

merged 2 commits into from Feb 21, 2020

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Feb 1, 2020

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Options is validated programmatically

What is the new behavior?

Options validated through schema, webpack will assist if given option is not match schema

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:
Closes #749

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ogonkov
Copy link
Contributor Author

ogonkov commented Feb 17, 2020

What should be done to get it merged @JLHwung ?

@JLHwung
Copy link
Contributor

JLHwung commented Feb 19, 2020

Hi @ogonkov, generally we have two-approval policy on merging PRs. Let's wait for a longer while. Thanks for your patience.

@ogonkov
Copy link
Contributor Author

ogonkov commented Feb 19, 2020

@JLHwung Can we invite someone here to review?

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use schema-utils for options validation
3 participants