Build for node 14.15.0 #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Oct 26, 2022
JLHwung
force-pushed
the
bump-babel-and-deps
branch
from
e2dd146
to
7248731
Compare
JLHwung
commented
Oct 26, 2022
| @@ -54,10 +57,10 @@ test.cb("should transpile the code snippet", t => { | |||
| t.true(files.length === 1); | |||
| fs.readFile(path.resolve(t.context.directory, files[0]), (err, data) => { | |||
| t.is(err, null); | |||
| const test = "var App = function App()"; | |||
| const test = "var App = function App(arg)"; | |||
There was a problem hiding this comment.
CI was failing because new Babel version generates slightly different outputs. I have updated the test Babel config and ensured that the test Babel config does not inherit root Babel config.
nicolo-ribaudo
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Build for Node.js 14.15.0 and update
@babel/*dev deps.