Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loader-utils dependecy to ^0.2.16 #371

Merged
merged 1 commit into from Feb 7, 2017
Merged

Conversation

leonaves
Copy link
Contributor

@leonaves leonaves commented Feb 7, 2017

Anything below 0.2.16 for loader-utils causes issues with webpack 2 (webpack/webpack#3060 (comment) and I have replicated the issue)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Webpack build fails with the error:

Module build failed: Error: parseQuery should get a string as first argument
    at Object.parseQuery (/path/to/node_modules/loader-utils/index.js:68:9)
    at Object.module.exports (/path/to/node_modules/babel-loader/lib/index.js:79:35)

What is the new behavior?

Webpack build succeeds

Does this PR introduce a breaking change?

  • Yes
  • No

Anything below 0.2.16 for loader-utils causes issues with webpack 2 (webpack/webpack#3060 (comment) and I have replicated the issue)
@danez
Copy link
Member

danez commented Feb 7, 2017

Thank you, although this new version will be picked up anyway as we use carret. But it also makes sense to increase the version.

@danez danez added the chore label Feb 7, 2017
@codecov-io
Copy link

Codecov Report

Merging #371 into master will not impact coverage.

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files           6        6           
  Lines         152      152           
  Branches       33       33           
=======================================
  Hits          123      123           
  Misses         13       13           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e3702...a038ea6. Read the comment docs.

@danez danez merged commit 0b19a6d into babel:master Feb 7, 2017
@deitch
Copy link

deitch commented Feb 8, 2017

Ah, spent the last little bit tracking this down. When does this get released to npm?

@danez
Copy link
Member

danez commented Feb 8, 2017

At some point, for now just remove your node_modules and install again.

@leonaves
Copy link
Contributor Author

leonaves commented Feb 8, 2017

I'm pretty sure if you have another dependency that hard requires 0.2.15 or below, npm will happily install the lower version and be content that it has satisfied the dependency of babel-loader.

@deitch
Copy link

deitch commented Feb 8, 2017

I'm pretty sure if you have another dependency that hard requires 0.2.15 or below, npm will happily install the lower version and be content that it has satisfied the dependency of babel-loader

Yes. For now, I basically removed babel-loader, added loader-utils@0.2.16 explicitly, then added babel-loader. It probably will blow up again if I do another install, but hopefully last long enough until this is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants