Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run to index #67

Merged
merged 3 commits into from Feb 9, 2022
Merged

run to index #67

merged 3 commits into from Feb 9, 2022

Conversation

davidgamero
Copy link
Collaborator

@davidgamero davidgamero commented Feb 8, 2022 •
edited

implement path and filename changes to support migration to ncc

OliverMKing
OliverMKing reviewed Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't ncc be a dev dependency?

@davidgamero
Copy link
Collaborator Author

i wasn't able to execute ngg unless it was global. how did you get it working?

@davidgamero
Copy link
Collaborator Author

oh nvm i figured it out

@davidgamero
Copy link
Collaborator Author

davidgamero commented Feb 8, 2022 •
edited

i was trying to test locally and forgot the packge is @vercel/ncc not just ncc. it's cool that it auto adds node_modules/bin when you use the package.json scripts

@gambtho gambtho merged commit fa870ea into Azure:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gambtho gambtho gambtho approved these changes

@OliverMKing OliverMKing OliverMKing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidgamero @gambtho @OliverMKing