Version fix #66
Merged
Version fix #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aamgayle
requested review from
davidgamero and
OliverMKing
and removed request for
davidgamero
tbarnes94
approved these changes
Feb 8, 2022
OliverMKing
requested changes
Feb 8, 2022
OliverMKing
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for v in version string and adds it if it doesn't already exist to address this issue. Also changed the last test in integration test to check for v in front of version.
Reproduced problem here: https://github.com/taakleton/setup-helm/runs/5114512803?check_suite_focus=true
Fixed issue here: https://github.com/taakleton/setup-helm/runs/5114479231?check_suite_focus=true