Adding CLI and PS error logs & optional audience parameter #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanika1894
changed the title
kaverma
reviewed
Nov 8, 2021
| @@ -121,7 +121,7 @@ jobs: | |||
| az group list | |||
| pwd | |||
| ``` | |||
| This action supports login az powershell as well for both windows and linux runners by setting an input parameter `enable-AzPSSession: true`. Below is the sample workflow for the same using the windows runner. Please note that powershell login is not supported in Macos runners. | |||
| Users can also specify `audience` field for access-token in the input parameters of the action. If not specified, it is defaulted to `api://AzureADTokenExchange`. This action supports login az powershell as well for both windows and linux runners by setting an input parameter `enable-AzPSSession: true`. Below is the sample workflow for the same using the windows runner. Please note that powershell login is not supported in Macos runners. | |||
There was a problem hiding this comment.
nit: we should have "This action supports login... " in a new line
kaverma
approved these changes
Nov 8, 2021
|
We need to update the documentation/readme to include the audience field |
kaverma
requested changes
Nov 9, 2021
There was a problem hiding this comment.
@BALAGA-GAYATRI, @N-Usha , should we have a security review to ensure whether we are good with all these claims in logs that anyone can see?
BALAGA-GAYATRI
added a commit
that referenced
this pull request
Nov 15, 2021
* cherry pick changes * added audience field option in input params * added js * removed extra spaces * Adding logs to surface AZ-CLI and powershell errors (#171) * removing token logs
BALAGA-GAYATRI
changed the title
|
Printing token logs changes are removed from this PR and will be done post security approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added federated token logs - sample output:
Also, added audience parameter (which will be optional) and defaults to ‘api://AzureADTokenExchange’