Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine best option to disable background (body) scroll when offcanvas nav is active #903

Open
joeparsons opened this issue Aug 25, 2023 · 3 comments
Assignees
Labels
2.0.x only bug Something isn't working

Comments

@joeparsons
Copy link
Member

Problem/Motivation

Follow-up to #887 / #889 to come up with a more complete fix for background/body scrolling still happening when off-canvas nav is activated on various mobile devices.

Describe the bug

On mobile devices (especially iOS?) the background/body of the page is still scrollable when the off canvas navbar is activated, even after the fixes applied for #887.

Proposed resolution

We discussed several potential options for addressing this issue in our 2023-08-25 Friday meeting including:

Expected behavior

The body/background should not be scrollable (or interact-able) when the off-canvas navbar is activated.

@joeparsons joeparsons added bug Something isn't working 2.0.x only labels Aug 25, 2023
@trackleft
Copy link
Member

Let's test the impact of this on core web vitals. I wonder if this is a real concern.

I do know that the mobile nav renders on initial page load and then moves off screen, which is probably a bigger problem.

If that were not the case, then I would say that we could set the height dynamically.

Alternatively, wait for the bootstrap 5 modal version of off-canvas nav

@Krystation
Copy link

Krystation commented Oct 17, 2023

Hey, just scrolling through trying to find a thing to work on. Is this task still relevant or if just going with bootstraps .offcanvas lass?

@joeparsons
Copy link
Member Author

Hey, just scrolling through trying to find a thing to work on. Is this task still relevant or if just going with bootstraps .offcanvas lass?

Hi @Krystation, I think this is still worth addressing in Arizona Bootstrap 2.0.x, if possible. Thanks!

@Krystation Krystation self-assigned this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.x only bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants