Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide what to do with offcanvasmenu component in 5.x #885

Open
joeparsons opened this issue Aug 15, 2023 · 0 comments · May be fixed by #886
Open

Decide what to do with offcanvasmenu component in 5.x #885

joeparsons opened this issue Aug 15, 2023 · 0 comments · May be fixed by #886
Assignees
@joeparsons
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request

Comments

@joeparsons
Copy link
Member

What is the problem that we want to solve?

Upstream Bootstrap 5 contains a generic OffCanvas component. We need to decide what to do with our custom Offcanvas Menu component. i.e.:

  • "Upgrade" our custom component with Bootstrap 5 conventions?
  • Replace our custom component with documented examples of providing the same functionality with the generic upstream Offcanvas component?
  • Deprecate or component?
@joeparsons joeparsons added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Aug 15, 2023
@joeparsons joeparsons self-assigned this Aug 15, 2023
joeparsons added a commit that referenced this issue Aug 15, 2023
@joeparsons
[WIP] #885: Upgrade Offcanvasmenu JS componenent to use upstream Boot…
207dd14 
…strap 5 conventions.
@joeparsons joeparsons linked a pull request Aug 15, 2023 that will close this issue
[WIP] #885: Upgrade Offcanvasmenu JS componenent to use upstream Bootstrap 5 conventions. #886
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeparsons joeparsons

Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@joeparsons