Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks on pull requests should include visual regression tests. #523

Open
mmunro-ltrr opened this issue Aug 2, 2022 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@mmunro-ltrr
Copy link
Member

Motivation

Arizona Bootstrap has no visual regression testing of proposed changes, although UA Bootstrap used to offer some.

Is your feature request related to a problem? Please describe.

A pull request can generate a completely broken review site, but not warn of this in any way.

Proposed Resolution

Describe the solution you'd like

Automated visual comparisons of the documentation site (internally built, not deployed) before and after a proposed change, with differences flagged as warnings (not blocking pull requests that add new features).

@trackleft
Copy link
Member

@mmunro-ltrr I made a working version of this for https://github.com/az-digital/arizona-gatsby/pull/423/files
I wonder if that would be useful

@mmunro-ltrr
Copy link
Member Author

@trackleft: interesting! I'd also been looking at what twbs has been doing (they're getting free support from BrowserStack). But this is a great ready-to-reuse option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants