Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv scaffolding for codegen #278

Merged
merged 2 commits into from May 23, 2022
Merged

riscv scaffolding for codegen #278

merged 2 commits into from May 23, 2022

Conversation

dave-tucker
Copy link
Member

Signed-off-by: Dave Tucker dave@dtucker.co.uk

@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for aya-rs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8b7950b
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs/deploys/628b95bc1cc12a0008ceedd3
😎 Deploy Preview https://deploy-preview-278--aya-rs.netlify.app/src/aya/generated/mod.rs
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@alessandrod alessandrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod.rs shouldn't be empty - it won't be generated

@alessandrod
Copy link
Collaborator

And we also need some boilerplate in src/lib.rs to import the riscv64 module

Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
@dave-tucker dave-tucker merged commit b71fe64 into aya-rs:main May 23, 2022
@dave-tucker dave-tucker added feature A PR that implements a new feature or enhancement aya-bpf This is about aya-bpf (kernel) aya This is about aya (userspace) labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aya This is about aya (userspace) aya-bpf This is about aya-bpf (kernel) feature A PR that implements a new feature or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants