Program unload API #264
Merged
Program unload API #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
davibe
force-pushed
the
feature/programs-unload
branch
7 times, most recently
from
1827f7a
to
1a06f76
Compare
davibe
force-pushed
the
feature/programs-unload
branch
from
1a06f76
to
08d5697
Compare
davibe
force-pushed
the
feature/programs-unload
branch
from
bf69377
to
4abaad6
Compare
dave-tucker
requested changes
Jun 2, 2022
There was a problem hiding this comment.
Thanks for this @davibe. I've left a few comments but I think this is almost there.
alessandrod
requested changes
Jun 2, 2022
alessandrod
reviewed
Jun 2, 2022
davibe
force-pushed
the
feature/programs-unload
branch
from
1fa4083
to
8b53d44
Compare
davibe
force-pushed
the
feature/programs-unload
branch
from
8b53d44
to
1aa0023
Compare
|
@dave-tucker are you happy with this now? If so imma squash and merge |
|
Yep LGTM |
davibe
added a commit
to davibe/aya
that referenced
this pull request
Jun 3, 2022
aya: add `program.unload()` API
dave-tucker
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API to unload programs