Getting rid of shitty upstream depedencies #35

ice1000 · 2021-09-08T22:50:53Z

We are currently suffering from the following projects:

Eclipse lsp4j, which is itself a shit mountain (doesn't work with jpms, caused a lot of installation/jlink problems, written in Java 8) and also has shit mountain dependencies (guava, xtext, xtend, etc.)
- I found an alternative, see Publish org.javacs.lsp? georgewfraser/java-language-server#197
- Published!
The badass jlink plugin of Gradle -- it is not itself a shit mountain (it's a great project), but it's designed for shit mountains. It aims at repackaging your fatJar into a jpms module and let jlink process it. Aya is built entirely with jpms, so if we have all upstream deps jpms-ed, we can get rid of this plugin entirely.
- ~~The plugin does not work with Java 19.~~
  - There are new maintainers now, works with latest Java
Gradle -- it is fine at the moment because we still want it to offer us the ability to publish to maven central, but Gradle is also designed for maven style projects. Ughh.
ANTLR4-runtime -- doesn't support jpms is the only problem (yet). Seems not very hard to repackage with jpms support.
- We've decided Use GK parser #466
Commonmark -- doesn't support jpms, written in Java 8 with a return-void visitor (Add jlink-compatible Java9/Jigsaw module-info (not automatic modules) commonmark/commonmark-java#125). I think we can take some code from it, repackage, and add jpms support.
- ~~There is an outdated attempt to add jpms: https://github.com/xzel23/commonmark-java/tree/0.14.0-jigsaw~~
- Already repackaged and redistrubuted, see https://github.com/aya-prover/commonmark-java
GSON -- it's a PROJECT FROM GOOGLE so it's gonna be a disaster to depend on it. However, it supports jpms, so I think it's fine to use it (well but people are complaining Move module-info.java to /src/main/java google/gson#1315 (comment)).
JImGui -- it doesn't yet have jpms support, but I can add it in a minute since it's my project, so it's a small problem.

Also, I propose removing the tgbot subproject since it's useless.

re-xyr · 2021-09-09T00:07:55Z

What is jpm?

ice1000 · 2021-09-09T00:13:20Z

What is jpm?

https://www.oracle.com/corporate/features/understanding-java-9-modules.html

re-xyr · 2021-09-09T00:32:49Z

Sounds like Java ecosystem is in a mess. Or probably this is true for every language...

ice1000 · 2021-09-09T02:09:32Z

Sounds like Java ecosystem is in a mess.

Yes, this is because Java didn't have a module system or package management system long time ago. The community designed a format called "POM" (probably by maven) and it became the de-facto standard, but starting from Java 9 there is a new, official one. Part of the community is not willing to change, but we're not one of 'em.

re-xyr · 2021-09-09T05:58:37Z

Seems to be a bad choice of Oracle for not officialize the community solution already.

ice1000 · 2021-09-09T12:37:58Z

Seems to be a bad choice of Oracle for not officialize the community solution already.

I don't know. There are pros and cons. The community solution relies on jars, while the official one is based on modules. By that, we can trim unused modules when packaging the application, giving rise to smaller releases. The jar-based solution often uses some hacks to remove unused classes

ice1000 · 2021-09-09T12:51:44Z

Also maybe it's hard for the standard library to be modularized in a way the community do

ice1000 · 2021-09-09T12:51:47Z

Idk

ice1000 · 2021-09-10T01:01:29Z

I decide to delay this until we reach some late-milestone, like 0.12 or 0.15, after some major language features are worked upon.

254: Use commonmark packaged by ourselves r=ice1000 a=ice1000 bors merge this part of #35 Co-authored-by: ice1000 <ice1000kotlin@foxmail.com>

ice1000 · 2022-09-24T21:05:54Z

runtimeClasspath - Runtime classpath of source set 'main'.
+--- org.eclipse.lsp4j:org.eclipse.lsp4j:0.15.0
|    +--- org.eclipse.lsp4j:org.eclipse.lsp4j.generator:0.15.0
|    |    +--- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.15.0
|    |    |    \--- com.google.code.gson:gson:[2.9.0,2.10) -> 2.9.1
|    |    \--- org.eclipse.xtend:org.eclipse.xtend.lib:2.24.0
|    |         +--- org.eclipse.xtext:org.eclipse.xtext.xbase.lib:2.24.0
|    |         |    \--- com.google.guava:guava:27.1-jre
|    |         |         +--- com.google.guava:failureaccess:1.0.1
|    |         |         +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    |         |         +--- com.google.code.findbugs:jsr305:3.0.2
|    |         |         +--- org.checkerframework:checker-qual:2.5.2
|    |         |         +--- com.google.errorprone:error_prone_annotations:2.2.0
|    |         |         +--- com.google.j2objc:j2objc-annotations:1.1
|    |         |         \--- org.codehaus.mojo:animal-sniffer-annotations:1.17
|    |         \--- org.eclipse.xtend:org.eclipse.xtend.lib.macro:2.24.0
|    |              \--- org.eclipse.xtext:org.eclipse.xtext.xbase.lib:2.24.0 (*)
|    \--- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.15.0 (*)
+--- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.15.0 (*)
\--- project :cli
     +--- project :base
     |    +--- project :tools
     |    |    +--- org.jetbrains:annotations:23.0.0
     |    |    +--- org.glavo.kala:kala-common:0.50.0
     |    |    |    +--- org.glavo.kala:kala-base:0.50.0
     |    |    |    +--- org.glavo.kala:kala-collection:0.50.0
     |    |    |    |    \--- org.glavo.kala:kala-base:0.50.0
     |    |    |    \--- org.glavo.kala:kala-collection-primitive:0.50.0
     |    |    |         +--- org.glavo.kala:kala-base:0.50.0
     |    |    |         \--- org.glavo.kala:kala-collection:0.50.0 (*)
     |    |    \--- project :pretty
     |    |         +--- org.jetbrains:annotations:23.0.0
     |    |         \--- org.glavo.kala:kala-common:0.50.0 (*)
     |    +--- project :pretty (*)
     |    +--- org.aya-prover.guest0x0:cubical:0.17.1
     |    |    \--- org.aya-prover:pretty:0.20 -> project :pretty (*)
     |    \--- org.aya-prover:commonmark:0.19.1
     +--- project :parser
     |    \--- org.antlr:antlr4-runtime:4.10.1
     +--- project :tools-repl
     |    +--- project :pretty (*)
     |    +--- project :tools (*)
     |    +--- org.jline:jline-reader:3.21.0
     |    |    \--- org.jline:jline-terminal:3.21.0
     |    +--- org.jline:jline-terminal:3.21.0
     |    \--- org.antlr:antlr4-runtime:4.10.1
     +--- com.google.code.gson:gson:2.9.1
     +--- info.picocli:picocli:4.6.3
     +--- org.jline:jline-terminal-jansi:3.21.0
     |    +--- org.fusesource.jansi:jansi:2.4.0
     |    \--- org.jline:jline-terminal:3.21.0
     \--- org.jline:jline-builtins:3.21.0
          +--- org.jline:jline-reader:3.21.0 (*)
          \--- org.jline:jline-style:3.21.0
               \--- org.jline:jline-terminal:3.21.0

ice1000 · 2022-09-24T21:07:48Z

Removing our own libraries:

runtimeClasspath - Runtime classpath of source set 'main'.
+--- org.eclipse.lsp4j:org.eclipse.lsp4j:0.15.0
|    +--- org.eclipse.lsp4j:org.eclipse.lsp4j.generator:0.15.0
|    |    +--- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.15.0
|    |    |    \--- com.google.code.gson:gson:[2.9.0,2.10) -> 2.9.1
|    |    \--- org.eclipse.xtend:org.eclipse.xtend.lib:2.24.0
|    |         +--- org.eclipse.xtext:org.eclipse.xtext.xbase.lib:2.24.0
|    |         |    \--- com.google.guava:guava:27.1-jre
|    |         |         +--- com.google.guava:failureaccess:1.0.1
|    |         |         +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
|    |         |         +--- com.google.code.findbugs:jsr305:3.0.2
|    |         |         +--- org.checkerframework:checker-qual:2.5.2
|    |         |         +--- com.google.errorprone:error_prone_annotations:2.2.0
|    |         |         +--- com.google.j2objc:j2objc-annotations:1.1
|    |         |         \--- org.codehaus.mojo:animal-sniffer-annotations:1.17
|    |         \--- org.eclipse.xtend:org.eclipse.xtend.lib.macro:2.24.0
|    |              \--- org.eclipse.xtext:org.eclipse.xtext.xbase.lib:2.24.0 (*)
|    \--- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.15.0 (*)
+--- org.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.15.0 (*)
\--- project :cli
     +--- project :base
     |    +--- project :tools
     |    |    +--- org.jetbrains:annotations:23.0.0
     |    |    \--- project :pretty
     |    |         +--- org.jetbrains:annotations:23.0.0
     +--- project :parser
     |    \--- org.antlr:antlr4-runtime:4.10.1
     +--- project :tools-repl
     |    +--- org.jline:jline-reader:3.21.0
     |    |    \--- org.jline:jline-terminal:3.21.0
     |    +--- org.jline:jline-terminal:3.21.0
     |    \--- org.antlr:antlr4-runtime:4.10.1
     +--- com.google.code.gson:gson:2.9.1
     +--- info.picocli:picocli:4.6.3
     +--- org.jline:jline-terminal-jansi:3.21.0
     |    +--- org.fusesource.jansi:jansi:2.4.0
     |    \--- org.jline:jline-terminal:3.21.0
     \--- org.jline:jline-builtins:3.21.0
          +--- org.jline:jline-reader:3.21.0 (*)
          \--- org.jline:jline-style:3.21.0
               \--- org.jline:jline-terminal:3.21.0

540: Use javacs language server r=ice1000 a=ice1000 A big step of #35 Co-authored-by: `@imkiva` bors r+ Co-authored-by: ice1000 <ice1000kotlin@foxmail.com> Co-authored-by: imkiva <imkiva@islovely.icu>

ice1000 assigned imkiva and Glavo and unassigned imkiva Sep 8, 2021

ice1000 transferred this issue from aya-prover/aya-prover-proto Sep 28, 2021

ice1000 unassigned imkiva and Glavo Nov 12, 2021

ice1000 added the help wanted Extra attention is needed label Nov 13, 2021

ice1000 mentioned this issue Dec 3, 2021

Use commonmark packaged by ourselves #254

Merged

bors bot added a commit that referenced this issue Dec 3, 2021

MERGE: #254

d169844

254: Use commonmark packaged by ourselves r=ice1000 a=ice1000 bors merge this part of #35 Co-authored-by: ice1000 <ice1000kotlin@foxmail.com>

ice1000 mentioned this issue Sep 23, 2022

How many of our runtime dependencies do not yet support JPMS? #536

Closed

ice1000 mentioned this issue Sep 25, 2022

Use javacs language server #540

Merged

bors bot added a commit that referenced this issue Sep 25, 2022

merge: #540

863a7f5

540: Use javacs language server r=ice1000 a=ice1000 A big step of #35 Co-authored-by: `@imkiva` bors r+ Co-authored-by: ice1000 <ice1000kotlin@foxmail.com> Co-authored-by: imkiva <imkiva@islovely.icu>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Getting rid of shitty upstream depedencies #35

Getting rid of shitty upstream depedencies #35

ice1000 commented Sep 8, 2021 •

edited

re-xyr commented Sep 9, 2021

ice1000 commented Sep 9, 2021

re-xyr commented Sep 9, 2021

ice1000 commented Sep 9, 2021

re-xyr commented Sep 9, 2021

ice1000 commented Sep 9, 2021

ice1000 commented Sep 9, 2021

ice1000 commented Sep 9, 2021

ice1000 commented Sep 10, 2021

ice1000 commented Sep 24, 2022

ice1000 commented Sep 24, 2022

Getting rid of shitty upstream depedencies #35

Getting rid of shitty upstream depedencies #35

Comments

ice1000 commented Sep 8, 2021 • edited

re-xyr commented Sep 9, 2021

ice1000 commented Sep 9, 2021

re-xyr commented Sep 9, 2021

ice1000 commented Sep 9, 2021

re-xyr commented Sep 9, 2021

ice1000 commented Sep 9, 2021

ice1000 commented Sep 9, 2021

ice1000 commented Sep 9, 2021

ice1000 commented Sep 10, 2021

ice1000 commented Sep 24, 2022

ice1000 commented Sep 24, 2022

ice1000 commented Sep 8, 2021 •

edited