Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports for upcoming DRF version #408

Merged
merged 3 commits into from Jul 16, 2019

Conversation

tfranzel
Copy link
Contributor

Came across this while working on a PR for DRF. Upstream changes to DRF will break drf-yasg with the release of 3.10. DRF is dropping Py2 support and did some refactorings.

Tests worked fine with DRF branch version-3.10 installed in the virtualenv

breaking DRF PR

Sidenote: I also had to create a PR for the dependency djangorestframework-camel-case as it will also break on 3.10.

@axnsan12
Copy link
Owner

Thanks for the initative, but your changes seem to break compatibility with older versions: https://travis-ci.org/axnsan12/drf-yasg/builds/558380899 (not sure why the PR status was not updated by Travis)

@tfranzel
Copy link
Contributor Author

Sure. I will have a look in an hour. DRF just released 3.10 a couple of hours ago. Yasg is broken as of now. A coworker just ran into exactly this issue 5 min ago :)

@tfranzel
Copy link
Contributor Author

ok took longer than anticipated but i got it done. there are multiple things:

  • to keep compatibility with old versions I needed to add an version check for >3.10 and below.
  • to make the tests work with 3.10 (and below) i had to add my PR of djangorestframework-camel-case to the testproj requirements until its gets merged. As of now the lib is broken.
  • added tox target for drf310
  • djmaster is only failing because corsheaders also uses from django.utils import six which got removed from master. honestly, didn't want to open up a third PR.

@axnsan12
Copy link
Owner

Awesome, thanks!

@axnsan12 axnsan12 merged commit 1904b04 into axnsan12:master Jul 16, 2019
@tfranzel tfranzel deleted the upstream-import-fix branch July 17, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants