Fix/typescript tests #5375
Merged
Fix/typescript tests #5375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � package-lock.json � package.json
… making an npm release;
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+159
to
+162
| await spawn(`npm test --prefix ${pkgPath}`, [], { | ||
| shell : true, | ||
| stdio: 'pipe' | ||
| }); |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments
Comment on lines
+176
to
+179
| await spawn(`npm test --prefix ${pkgPath}`, [], { | ||
| shell : true, | ||
| stdio: 'pipe' | ||
| }); |
Check warning
Code scanning / CodeQL
Superfluous trailing arguments
DigitalBrainJS
force-pushed
the
fix/typescript-tests
branch
from
a86a669
to
fb8e289
Compare
| }); | ||
| .catch((error) => { | ||
| if (axios.isAxiosError(error)) { | ||
| const axiosError: axios.AxiosError = error; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
refactor(test): refactor typescript tests;
DigitalBrainJS
force-pushed
the
fix/typescript-tests
branch
from
fb8e289
to
7e02f5f
Compare
|
|
||
| // issue #5034 | ||
|
|
||
| function getRequestConfig1(options: AxiosRequestConfig): AxiosRequestConfig { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| }; | ||
| } | ||
|
|
||
| function getRequestConfig2(options: AxiosRequestConfig): AxiosRequestConfig { |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release:no-npmscriptindex.d.tstypes (mainly headers types)tsc --noEmitinstead ofdtslint