Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix axios.delete ignores config.data #3282

Merged
merged 2 commits into from Oct 1, 2020

Conversation

chinesedfan
Copy link
Collaborator

Fixes #3220. As explained in #3220 (comment).

@cuongdevjs
Copy link

How long this pr merged and release?

@ngajhede
Copy link

ngajhede commented Sep 18, 2020

Yes please. This is currently breaking parts of our application.

A temporary solution is to use axios.request:
axios.request({data, url, method: 'delete'});

Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I think this will help us with potentially breaking changes in the future.

Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonsaayman jasonsaayman merged commit fa36737 into axios:master Oct 1, 2020
@DanielIndie95
Copy link

@jasonsaayman why isnt that released yet? As I can see that the latest version is still 0.20.0

@MwumLi
Copy link

MwumLi commented Oct 12, 2020

@jasonsaayman why isnt that released yet? npm version not match github tag

@lifesboy
Copy link

When will this version be released, please?

@pholleyad
Copy link

Adding another request for this to be released as well. Thanks @ngajhede for the workaround!

@jasonsaayman
Copy link
Member

Hi All,

I am not able to do the release, only Emily can, I have spoken to her and I think we should see the release over the weekend.

Thanks

@rlightner
Copy link

@jasonsaayman any word from @emilyemorehouse?

@jasonsaayman
Copy link
Member

I have asked again today to see when the release will happen, will update this thread as soon as I know whats going on.

@jasonsaayman
Copy link
Member

Hi,

Version 0.21.0 has been released 🎉 please use that and let us know if that solves your issue.

Thanks

This was referenced Mar 18, 2021
mbargiel pushed a commit to mbargiel/axios that referenced this pull request Jan 27, 2022
Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axios does not use data from config when making DELETE request
9 participants