Correctly pass agents to follow-redirects #2547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvyasedh
approved these changes
Nov 13, 2019
yasuf
approved these changes
Nov 14, 2019
|
If I get a chance I'll merge a few PRs and add them to the 0.19.1 release, this one (although a really good fix) doesn't seem urgent to ship right away If this is urgent for you, change the base to be the 0.19 PR branch and update the changelog and it'll go out on 0.19.1 |
|
also you'll need to update the |
|
This PR should be part of 0.19.1 because #2426 will introduce a regression in 0.19.1 for anyone using http(s)Agent. I'll update the base of this PR and the changelog. Not sure if a dist change is required because this is only a change to |
|
Closed in favor of yasuf#1 |
This was referenced Jan 7, 2020
This was referenced Apr 3, 2020
Closed
This was referenced Apr 13, 2020
This was referenced Apr 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2546