Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axios create url bug #2290

Merged
merged 5 commits into from Sep 6, 2019
Merged

Conversation

dhrubesh
Copy link
Contributor

When using the request() method on an instance, the request would be successful even if the instance's config has url specified, but not baseUrl.

@dhrubesh
Copy link
Contributor Author

dhrubesh commented Jul 17, 2019

This PR solves #2234 .

G07cha pushed a commit to fed135/soixa that referenced this pull request Aug 10, 2019
Squashed from axios#2290:

fixing url issue while instance request

added spacing --eslint

added test cases

removed unexpected cases after updating the code
@felipewmartins
Copy link
Collaborator

Hi @dhrubesh, are you can update your local branch?

@felipewmartins felipewmartins merged commit 89bd3ab into axios:master Sep 6, 2019
felipewmartins added a commit to felipewmartins/axios that referenced this pull request Sep 13, 2019
genie-youn pushed a commit to genie-youn/axios that referenced this pull request Sep 27, 2019
* Fix axios#2234 

* added spacing --eslint

* added test cases

* removed unexpected cases after updating the code
genie-youn pushed a commit to genie-youn/axios that referenced this pull request Sep 27, 2019
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants