Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue 2195 #2201

Merged
merged 2 commits into from Sep 13, 2019
Merged

Conversation

masterots
Copy link
Contributor

Fixes #2195

The order of the if/else blocks matters when running tests mocking XHR. Changing the order allows this to continue working in node and browsers, but also allows for unit tests to properly connect over the correct protocol.

Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it seems that this does not break anything however it does definitely mend #2195

@jmelvin-r7
Copy link

@emilyemorehouse would it be possible to get an ETA for when this could be merged? I'd like to update my team/management on the fix for this issue.

@jmelvin-r7
Copy link

Is anyone able to merge changes other than @emilyemorehouse? This is becoming a hindrance to us continuing to use this library, if we can't get timely responses to get fixes handled.

@jasonsaayman
Copy link
Member

@jmelvin-r7, unfortunately, I think its only Emily and the three other original maintainers at this time.

@hendrikskevin
Copy link

@emilyemorehouse @mzabriskie @nickuraltsev @rubennorte Going to tag all of you. This issue is really becoming a bother and a forced downgrade to 0.18.0 is the only way to prevent it, but if this PR can be merged and a new release (0.19.1?) be made that would be great.

@felipewmartins felipewmartins merged commit 1b07fb9 into axios:master Sep 13, 2019
@jmelvin-r7 jmelvin-r7 deleted the hotfix/failing-xhr-tests branch September 13, 2019 13:35
genie-youn pushed a commit to genie-youn/axios that referenced this pull request Sep 27, 2019
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.19.0 no longer works with xhr-mock
7 participants