From 43461ff536aa24a1f1a7cc370cb2498a0d448293 Mon Sep 17 00:00:00 2001 From: Angelos Chalaris Date: Mon, 1 Oct 2018 22:14:44 +0300 Subject: [PATCH 1/4] Update utils.js --- lib/utils.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/utils.js b/lib/utils.js index 8946055dac..49b4cd1a1a 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -1,7 +1,6 @@ 'use strict'; var bind = require('./helpers/bind'); -var isBuffer = require('is-buffer'); /*global toString:true*/ @@ -19,6 +18,17 @@ function isArray(val) { return toString.call(val) === '[object Array]'; } + +/** + * Determine if a value is a Buffer + * + * @param {Object} val The value to test + * @returns {boolean} True if value is a Buffer, otherwise false + */ +function isBuffer(val) { + return ![, null].includes(val) && val.constructor === Buffer; +} + /** * Determine if a value is an ArrayBuffer * From d483bd4135faf63d680431496098e978d3d87db6 Mon Sep 17 00:00:00 2001 From: Angelos Chalaris Date: Mon, 1 Oct 2018 22:15:25 +0300 Subject: [PATCH 2/4] Remove dependency on is-buffer from package.json --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index 2229ce19f8..37f6d8a59a 100644 --- a/package.json +++ b/package.json @@ -73,8 +73,7 @@ }, "typings": "./index.d.ts", "dependencies": { - "follow-redirects": "^1.4.1", - "is-buffer": "^2.0.2" + "follow-redirects": "^1.4.1" }, "bundlesize": [ { From 9a6c53821db7ed0050ac92cadb48a8a47858457e Mon Sep 17 00:00:00 2001 From: Angelos Chalaris Date: Mon, 1 Oct 2018 22:22:19 +0300 Subject: [PATCH 3/4] Update utils.js --- lib/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils.js b/lib/utils.js index 49b4cd1a1a..c985b0a954 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -26,7 +26,7 @@ function isArray(val) { * @returns {boolean} True if value is a Buffer, otherwise false */ function isBuffer(val) { - return ![, null].includes(val) && val.constructor === Buffer; + return ![undefined, null].includes(val) && val.constructor === Buffer; } /** From ef01eefc16ff2e41c2c4845306f04060b62907ca Mon Sep 17 00:00:00 2001 From: Angelos Chalaris Date: Sat, 16 Nov 2019 12:51:29 +0200 Subject: [PATCH 4/4] Update isX.spec.js --- test/specs/utils/isX.spec.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/specs/utils/isX.spec.js b/test/specs/utils/isX.spec.js index 08fa2c4462..2d301c730d 100644 --- a/test/specs/utils/isX.spec.js +++ b/test/specs/utils/isX.spec.js @@ -7,6 +7,12 @@ describe('utils::isX', function () { expect(utils.isArray({length: 5})).toEqual(false); }); + it('should validate Buffer', function () { + expect(utils.isBuffer(Buffer.from('a'))).toEqual(true); + expect(utils.isBuffer(null)).toEqual(false); + expect(utils.isBuffer(undefined)).toEqual(false); + }); + it('should validate ArrayBuffer', function () { expect(utils.isArrayBuffer(new ArrayBuffer(2))).toEqual(true); expect(utils.isArrayBuffer({})).toEqual(false);