New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set baseURL in interceptors is not working. #949
Comments
look me Custom instance defaults axios.all is not a function #948 my working normal only all is not a function |
Experienced the same issue. It might be more of a conceptual issue than an implementation detail. Seems to me that setting a baseURL is a way of saying "prepend this to every request", which seems kind of pointless when you set it on every request. Although a case could definitely be made for a conditional like:
But it doesn't work. Setting a global default like this does: In both cases the 'url' field of the config is 'https://example.com/extra', but setting the baseURL in the interceptor only updates 'config.baseURL'. I mean it makes sense why, you're literally just updating that field, but it would be nice if it updated the url field as well or at least mentioned in the docs (preferably in big bold lettering) that setting baseURL in an interceptor is useless/not recommended. @Baoyx007 you can always just change the 'url' value in the config manually
or on every request
Node v7.10.0 |
Fixed in #950 |
#### Summary
set baseURL in interceptors is not working.
#### Context
The text was updated successfully, but these errors were encountered: