-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggesting to use rollup for builds #940
Comments
We can explore this but I being honest I don't think it's a priority for the moment. |
I submit a PR to replace webpack with rollup. |
By now webpack 3 migration is merged #1334, also by now we have webpack 4 so it might be a good idea to think again webpack vs rollup but for now this issue is probably to close @emilyemorehouse. |
We are already using webpack, which should be updated to the latest version with #3718 |
I'm not talking about webpack. It's too heavy for simple job. I suggesting a rollup instead |
I understand but we are using webpack 4 now, is there any significant reason why we should change the tool we use? |
Well, let me know, also keep in mind that there is a planned upgrade to provide more module types thing ESM etc as well as maybe a full typescript based re-write. Also what about Parcel? |
Probably the main reason is that rollup really good at bundle size. Parcel - the latest one does not yet able to bundle the module without the issues. To many bugs (not stable) and also to heavy I would also give a try with https://github.com/developit/microbundle |
Ok cool, thanks @FDiskas if you would like you could look at either a plan as to how we could migrate to rollup or even look at putting in a pull request? I am adding this to my tasks too. |
I would love to make it happen. Not sure about my free time but I will try to make PR with a concept
Su pagarba,
Vytenis
tel.: +370 643 77855
…On May 5, 2021, 08:47 +0300, Jay ***@***.***>, wrote:
Ok cool, ***@***.*** if you would like you could look at either a plan as to how we could migrate to rollup or even look at putting in a pull request? I am adding this to my tasks too.
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sure, well even if you can just start with a concept on the other thread
just telling me what you would look at etc
…On Wed, 05 May 2021 at 07:53, Vytenis ***@***.***> wrote:
I would love to make it happen. Not sure about my free time but I will try
to make PR with a concept
Su pagarba,
Vytenis
tel.: +370 643 77855
On May 5, 2021, 08:47 +0300, Jay ***@***.***>, wrote:
> Ok cool, thanks @FDiskas if you would like you could look at either a
plan as to how we could migrate to rollup or even look at putting in a pull
request? I am adding this to my tasks too.
> —You are receiving this because you were mentioned.Reply to this email
directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#940 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEXNCMHAIXRBBCNX7GJQB3TMDML5ANCNFSM4DOJMS7Q>
.
|
What I'm going to do
1. Get rid of dist
2. Remove typedefinition files and generate them instead
3. Rewrite everything to typescript
4. Move from travis to github actions
5. Implement auto releases so that not only core maintainer could release package
6. introduce microbundle for bundling
|
We should probably collaborate as I am already working on most of this. Let me know |
More info could be found at https://rollupjs.org
https://code.lengstorf.com/learn-rollup-js/
The text was updated successfully, but these errors were encountered: