Buffer module ends up in production build

[davscro]

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

I'm not sure is this bug or excepted behaviour but I believe it's a bug. Running yarn build to generate production build, buffer module ends up in production build!

 "scripts": {
    "build": "set NODE_ENV=production rimraf build/dist && webpack -p --config webpack/webpack.config.js && npm run bundle_check",
    "bundle_check": "babel-node bundle_check.js"
  },

Could someone explain me why this package ends up in production build. Am I missing something?

yarn why buffer

yarn why node-libs-browser

And webpack is specified only as dev dependency.
I pointed this issue to WEBPACk but they answered it's connected with axios. Then I searched your repo and found the usage within the HTTP adapter

What is the expected behavior?
Buffer module should not be in production build.

Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.

axios: 0.16.1,
Webpack: 2.5.1
Node: 7.8.0
OS: OSX Sierra

Thanks in advance,
Davor

[nickuraltsev]

Fixed via #887.

[davscro]

hey @nickuraltsev, #887 is not fixing this issue.