Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isStandardBrowserEnv not working properly #728

Closed
Viktor6713 opened this issue Feb 24, 2017 · 1 comment
Closed

isStandardBrowserEnv not working properly #728

Viktor6713 opened this issue Feb 24, 2017 · 1 comment

Comments

@Viktor6713
Copy link
Contributor

Hello we are using axios with react native and react-native-signalr lib.
The signalr does something with document due to which axios in isStandardBrowserEnv is not properly determining where its running and tries to read cookies in react native app and fails.
I propose we detect react native from navigator.product as it was introduced in this commit for react native:
https://github.com/facebook/react-native/commit/3c65e62183ce05893be0822da217cb803b121c61

@nickuraltsev
Copy link
Member

Fixed via #731

@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants