New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE8 is determined wrong as non standard browser environment. #597

Closed

eu81273 opened this issue Dec 15, 2016 · 1 comment

eu81273 commented Dec 15, 2016 •

edited

In IE8, the value of typeof document.createElemen is object, not function so this isStandardBrowserEnv returns false.

function isStandardBrowserEnv() {
  return (
    typeof window !== 'undefined' &&
    typeof document !== 'undefined' &&
    typeof document.createElement !== 'function'
  );
}

Because of this wrong determine, XDomainRequest is not working in IE8. I made a pull request for fix this, but failed to pass the CI.

The text was updated successfully, but these errors were encountered:

eu81273 added a commit to eu81273/axios that referenced this issue


          Fix bug with isStandardBrowserEnv (axios#597)

a87e0b7

Viktor6713 mentioned this issue

Proper detection of react-native in isStandardBrowserEnv function #731

Merged

Member

nickuraltsev commented Mar 2, 2017

Fixed by #731. Thank you!

nickuraltsev closed this as completed

axios locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.