Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github CI build badge is broken on default v1.x branch #5461

Closed
EFord36 opened this issue Jan 11, 2023 · 0 comments · Fixed by #5462
Closed

Github CI build badge is broken on default v1.x branch #5461

EFord36 opened this issue Jan 11, 2023 · 0 comments · Fixed by #5462

Comments

@EFord36
Copy link
Contributor

EFord36 commented Jan 11, 2023

Section/Content To Improve

In the README.md, on the default branch v1.x, in the badges, the 'CI' badge shows with a link to a shields issue rather than an actual CI status.

Suggested Improvement

Hi,

I saw that the 'CI' badge was broken for axios on the 'default' v1.x branch - it looks like it's #5046 that breaks it on v1.x - v1 and main are both fine.

Update the url to remove the shields issue link and link to the actual CI status.

Currently badge looks like:

Screenshot 2023-01-11 at 11 27 33

The shields link explains the issue, but in summary, these badges were changed in a breaking fashion that means they need a url update, so the badges were changed to just link to the github issue rather than showing the data.

Updating the url from:

https://img.shields.io/github/workflow/status/axios/axios/ci?label=CI&logo=github&style=flat-square

to

https://img.shields.io/github/actions/workflow/status/axios/axios/ci.yml?branch=v1.x&label=CI&logo=github&style=flat-square

solves this (although note that I've specified the branch as v1.x - unclear to me if this is correct, or if it should be main, or something else.

Relevant File(s)

README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant