Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release the fix version as soon as possible to fix the decoding bug. #5337

Closed
izhouteng opened this issue Dec 4, 2022 · 4 comments
Closed

Comments

@izhouteng
Copy link

Describe the bug

It's unbelievable that the current version has such a major bug.

Hope to release the 1.2.1 fix immediately.

To Reproduce

No response

Code snippet

No response

Expected behavior

No response

Axios Version

No response

Adapter Version

No response

Browser

No response

Browser Version

No response

Node.js Version

No response

OS

No response

Additional Library Versions

No response

Additional context/Screenshots

No response

@mrinc
Copy link

mrinc commented Dec 4, 2022

I'll add some more info to this request:

Example URL: https://ghostfibre.com/wp-json/wp/v2/posts?per_page=1
Content-Type: application/json; charset=UTF-8

Forcing response encoding doesn't help at all either. (responseEncoding)

Affected versions: v1.2.0

The decoding/encoding of the responses are not functional.

Example Partial Response when using v1.2.0:

�w0[N����pPSM手ڷ�b������A��<��(���0�;ÔEH���)� ��3pO0�u8hP���tG'����ou��A�r����'��I�P����:�^�Y�T'yB��U%٣��
                                                                                                         {ڊc    hG�je��ŋ�\���   ���ۧ+�}�
                                                                                                                                       >)       �
i���^�y���샞G1��<΂M�!8\���m4cBew?�h�m{�z��c�����dAx����5�\��X�c�,��mܚ�`@        P

Example Partial Response when using v1.1.3:


  {
    id: 2067,
    date: '2021-11-29T00:45:00',
    date_gmt: '2021-11-28T22:45:00',
    guid: { rendered: 'https://ghostfibre.com/?p=2067' },
    modified: '2021-11-29T00:47:53',
    modified_gmt: '2021-11-28T22:47:53'

@philBrown
Copy link

Hope to release the 1.2.1 fix immediately.

Don't count on it. The devs seem allergic to patch releases for some reason

#5306 (comment)

@zacanger
Copy link

zacanger commented Dec 5, 2022

+1 on a quick release, please. This has been haunting StackOverflow for almost two weeks (hi Phil), I can't imagine how much havoc it's causing elsewhere

@jasonsaayman
Copy link
Member

Thanks I will release this tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants