Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove git credentials after checkout #5235

Merged
merged 3 commits into from Nov 22, 2022
Merged

ci: remove git credentials after checkout #5235

merged 3 commits into from Nov 22, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Nov 8, 2022

This PR removes Git credentials/SSH keys after checkout as a security precaution by setting persist-credentials to false, they are not used after the initial checkout.

Copy link
Member

@jasonsaayman jasonsaayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks 🚀

@jasonsaayman jasonsaayman merged commit 86eeff0 into axios:v1.x Nov 22, 2022
@Fdawgs Fdawgs deleted the ci/creds branch November 22, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants