Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How stable is v1? #5114

Closed
KrisLau opened this issue Oct 12, 2022 · 6 comments
Closed

How stable is v1? #5114

KrisLau opened this issue Oct 12, 2022 · 6 comments

Comments

@KrisLau
Copy link

KrisLau commented Oct 12, 2022

Describe the issue

Hi, really appreciate all the work that's being done on the library now! I'm deciding whether or not to upgrade from v0.27.2 to v1.1.2 or if I should wait for a more stable version. I'm unsure how stable v1 is as I've seen a bunch of issues related to v1. I also was wondering if there will be a migration guide written for upgrading to v1.

Example Code

N/A

Expected behavior, if applicable

N/A

Environment

  • Axios Version - v0.27.2
  • Adapter - HTTP
  • Browser - N/A
  • Browser Version - N/A
  • Node.js Version - v16.16.0
  • OS: - N/A
  • Additional Library Versions - React Native v0.69.6

Additional context/Screenshots

N/A

@ghost
Copy link

ghost commented Oct 12, 2022

FWIW there are a few breaking changes (paramsSerializer behavior is completely different), plus the documentation needs to be updated. There is a PR to resolve the Params Serializer issue and update some of the docs. See #5108

@ddolcimascolo
Copy link

It's not. The Jest tests breakage is a show stopper by itself, there's the paramsSerializer issue @EfChouTR is talking about, the set-cookie header issue, and the long list of open, unrsponded issues.

@KieraDOG
Copy link

there are few typescript break changes as well,

ie. you are no longer allowed to do this in axios v1 ts

api.interceptors.response.use((response: AxiosResponse): unknown => response.data)

@jasonsaayman
Copy link
Member

Yeah, there are a couple of issues, and I am trying to resolve a lot of them. Will be working on getting it more stable tonight. Staying on v0.27.2 is still an option, we are not dropping support for that and a new v0.xx version will be released soon.

@KrisLau
Copy link
Author

KrisLau commented Oct 13, 2022

Yeah, there are a couple of issues, and I am trying to resolve a lot of them. Will be working on getting it more stable tonight. Staying on v0.27.2 is still an option, we are not dropping support for that and a new v0.xx version will be released soon.

Sounds good, thanks for all the great work!

@KrisLau KrisLau closed this as completed Oct 13, 2022
@KrisLau
Copy link
Author

KrisLau commented Mar 30, 2023

@jasonsaayman Hi, sorry to bother but I just wanted to check in with a related question! Will there be an announcement made when a stable version is reached? I'm unsure when I should start migrating to v1 and just wanted to know if there will be an official announcement or if I would need to figure that out on my own (or if a stable version has already been reached).

Also will there will be a migration guide written for upgrading to v1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants