New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add Pre 1.x Functionality for ParamsSerializer #5107
Comments
It seems that |
Good catch; I wonder if we can update the main meat of their toString function for serializing the params to omit undefined and null. Feel free to make suggestions on #5108! I just wanted some of the old functionality back 😅 |
@FlorisVeldhuizen I added a couple of commits to #5108 which should (hopefully) resolve the issues with nulls and undefined? I added a test and found nulls are being included, but undefined fields are not |
Updated my PR because they still havent reconciled the null bug, but instead caused merge conflicts and duplicated efforts. 🤷 |
@FlorisVeldhuizen this is merged, but not yet released |
Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
#4734 Changed the entire behavior of the params serializer, breaking using any custom functionality on the consumer side. Add a boolean switch to mimic pre 1.x behavior (default is false) and send the params directly to the encode function
Describe alternatives you've considered
Tried working with new solution; it did not pan out well and led to more bugs with our requests
The text was updated successfully, but these errors were encountered: