Fixed handling of array values for AxiosHeaders; #5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejahmie
reviewed
Oct 11, 2022
| @@ -222,13 +216,13 @@ Object.assign(AxiosHeaders.prototype, { | |||
| return this; | |||
| }, | |||
|
|
|||
| toJSON: function() { | |||
| toJSON: function(asStrings) { | |||
There was a problem hiding this comment.
When is toJSON used? Cannot see anywhere where it is used with asString === true?
Are there cases where one wants arrays to be returned as string?
There was a problem hiding this comment.
When is toJSON used?
at least in test cases to make deep assertions, but...
asString === true
AxiosHeaders is a public class, so not 100% of its functionality should be used inside the Axios codebase, from the user's point of view, it should be a complete helper implementation for dealing with headers.
jasonsaayman
approved these changes
Oct 13, 2022
|
Was upgrading axios and discovered this issue, came here to see if had any quickfix and already fixed and working perfect! Thank you so much! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed handling of
set-cookieheaders as an array;Closes #5028, #5083;