Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using config.beforeRedirect prevents using proxy on redirected requests #4703

Closed
mbargiel opened this issue May 10, 2022 · 0 comments · Fixed by #4708
Closed

Using config.beforeRedirect prevents using proxy on redirected requests #4703

mbargiel opened this issue May 10, 2022 · 0 comments · Fixed by #4708

Comments

@mbargiel
Copy link
Contributor

mbargiel commented May 10, 2022

Describe the bug

The support for config.beforeRedirect introduced a regression of #3369 when both config.beforeRedirect and a proxy are used. Both of them internally set options.beforeRedirect. Moreover, config.beforeRedirect is not re-applied on subsequent redirections.

To Reproduce

Adding the following test in test/unit/adapters/http.js

  it('should support beforeRedirect and proxy with redirect', function (done) {
    var requestCount = 0;
    var totalRedirectCount = 5;
    server = http.createServer(function (req, res) {
      requestCount += 1;
      if (requestCount <= totalRedirectCount) {
        res.setHeader('Location', 'http://localhost:4444');
        res.writeHead(302);
      }
      res.end();
    }).listen(4444, function () {
      var proxyUseCount = 0;
      proxy = http.createServer(function (request, response) {
        proxyUseCount += 1;
        var parsed = url.parse(request.url);
        var opts = {
          host: parsed.hostname,
          port: parsed.port,
          path: parsed.path
        };

        http.get(opts, function (res) {
          response.writeHead(res.statusCode, res.headers);
          res.on('data', function (data) {
            response.write(data)
          });
          res.on('end', function () {
            response.end();
          });
        });
      }).listen(4000, function () {
        var configBeforeRedirectCount = 0;
        axios.get('http://localhost:4444/', {
          proxy: {
            host: 'localhost',
            port: 4000
          },
          maxRedirects: totalRedirectCount,
          beforeRedirect: function (options) {
            configBeforeRedirectCount += 1;
          }
        }).then(function (res) {
          assert.equal(totalRedirectCount, configBeforeRedirectCount, 'should invoke config.beforeRedirect option on every redirect');
          assert.equal(totalRedirectCount + 1, proxyUseCount, 'should go through proxy on every redirect');
          done();
        }).catch(done);
      });
    });
  });

Expected behavior

The test should pass, but currently 'should go through proxy on every redirect' assertion fails.

Environment

  • Axios Version 0.27.2
  • Adapter HTTP
  • Browser N/A
  • Browser Version N/A
  • Node.js Version N/A
  • OS: N/A
  • Additional Library Versions N/A

Additional context/Screenshots

I'm working on a small PR to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant