Fixing removing package-lock from gitignore #4346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the maintainers are using yarn. But no matter what it is, a lock file must be included in the github repo. |
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed package-lock.json from .gitignore, this adheres to the guidelines provided by npm found here
Fixes #4324 Package-lock.json file should be committed
Providing a package-lock makes for a more consistent experience for both end users and developers. While it is unlikely that issues would arise from a minor bump in transitive dependencies, it is still a possibility.