New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript: No insecureHTTPParser
property
#4044
Comments
Hello! 馃憢 This issue is being automatically closed because it does not follow the issue template. Please read the issue template carefully and follow all of the instructions when opening a new issue. Thanks |
https://github.com/axios/axios/commits/master/.github/workflows/close-issues.yml @chinesedfan @jasonsaayman (since you both created the file). As a maintainer of an open source project myself, I totally understand the purpose of encouraging users to follow an issue template. However, please reconsider automatically closing issues that don't follow the template. Adding a label and prioritizing it lower, and closing upon manual review is a far more positive solution. There is a clear purpose for having this issue open. Which is to help try to prevent duplicate PRs from being created and to link a PR to an issue (especially since there are currently 80 open PRs). There is ABSOLUTELY no purpose for me to spend extra time filling out the entire issue template when the intention is to create an issue to link a quick & simple PR to. Automatically closing the issue due to not following the issue template (in this case) just discourages people from contributing to the project. There is a fine balance there, and I believe this goes too far. Hopefully my PR is helpful. And hopefully this will be reconsidered in the future. |
The
insecureHTTPParser
property that was added in #2930 never got added to the TypeScript typings.@fabiel-leon @jasonsaayman Please be aware of this for future PRs 馃槂.
The text was updated successfully, but these errors were encountered: