New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading verbiage around supported HTTP methods #3140
Comments
Please can you put a pull request in for this change? I will gladly accept. |
The same applies to the TypeScript definitions: Lines 24 to 34 in 69949a6
@jasonsaayman Does Axios support any string you pass it, or is there a specific subset? Opened a PR: #3802 |
rijkvanzanten
added a commit
to rijkvanzanten/axios
that referenced
this issue
May 17, 2021
jasonsaayman
added a commit
that referenced
this issue
Mar 8, 2022
Fixes #3140 Co-authored-by: Jay <jasonsaayman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Section/Content To Improve
Section: Request method aliases
Quote: "For convenience aliases have been provided for all supported request methods."
Suggested Improvement
The key word in the quote is "supported". This suggests to me that anything not listed is not supported.
search
is not in the list, which implies that the SEARCH method is not supported. However, I tried the following:and it successfully sent a SEARCH request. This shows that the SEARCH method is actually supported. So, I would change the word "supported" to "common". And while we are at it, there needs to be a comma after "convenience". So the improved quote would read:
"For convenience, aliases have been provided for all common request methods."
Relevant File(s)
https://github.com/axios/axios/blob/master/README.md
The text was updated successfully, but these errors were encountered: