-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The adapter's config.url of axios 0.19.1 and above dosn't include baseURL, but axios 0.19.0 and below includes baseURL. #2917
Comments
Hi JihuYu, I am looking into it, I have validated that this does happen. Interesting to note is that if one is to do it like this: const axios = require("axios");
const instance = axios({
baseURL: "https://httpbin.org"
});
instance.get("/get")
.then((response) => {
console.log("axios@0.19.1: ", response.data);
}); You do end up with the call working successfully. I will look into the issue further and let you know. |
See discussions in #2751. |
I think it should be consistent because many adapters rely on |
Describe the bug
The adapter's config.url of axios 0.19.1 and above dosn't include baseURL, but axios 0.19.0 and below includes baseURL.
To Reproduce
I provide an example of running online: https://jsfiddle.net/r70u4wfs/, just change the axios's version, see the log of adapter config.
Expected behavior
Different versions should have the same performance. Version 0.19.1 and above should also contain baseURL.
Environment:
Additional context/Screenshots
Version 0.19.1 and above: dosn't include baseURL
Version 0.19.0 and below: includes baseURL
The text was updated successfully, but these errors were encountered: