-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moxios not working in 0.19.1 #2650
Comments
@neomedeiros Can you provide detailed code examples or error messages, as the issue template required? |
Maybe you can find the culprit with |
I've got no error message in my real-world project, the stubRequest() function simply did not stub a given request. I've just tried to create a minimal project in order to reproduce the error, but without success. Everything is working fine: https://github.com/neomedeiros/axios-2650 I will try to get more details about the issue in the real-world project. |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ @neomedeiros I think the issue is if you change axios.get('/todos', { baseURL: 'https://...' }) I'm finding that if I do |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ It broke here: https://github.com/brandon-leapyear/axios/commit/6fe506fda290ba935c2641f68f1fcba7f4a16cd3 Will try to put up a PR soon |
Hello! 👋 This issue is being automatically marked as stale because it has not been updated in a while. Please confirm that the issue is still present and reproducible. If no updates or new comments are received the issue will be closed in a few days. Thanks. |
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨ this issue still has open PRs against it |
@brandon-leapyear See #2751 (comment). Can you check for that? |
Hello! 👋 This issue is being automatically marked as stale because it has not been updated in a while. Please confirm that the issue is still present and reproducible. If no updates or new comments are received the issue will be closed in a few days. Thanks. |
@brandon-leapyear @chinesedfan have you all not achieved consensus on a fix for this? |
- remove moxios which doesn't work anymore since axios@>=0.19.1 (axios/axios#2650) - replace it with axios-mock-adapter (https://github.com/ctimmerm/axios-mock-adapter)
* chore(deps): bump axios from 0.19.0 to 0.21.1 Bumps [axios](https://github.com/axios/axios) from 0.19.0 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.19.0...v0.21.1) Signed-off-by: dependabot[bot] <support@github.com> * chore: adapt failing tests due to axios bump - remove moxios which doesn't work anymore since axios@>=0.19.1 (axios/axios#2650) - replace it with axios-mock-adapter (https://github.com/ctimmerm/axios-mock-adapter) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: woyuen <wing-on@stelace.com>
Moxios last version (0.4.0) just stopped working with Axios 0.19.1.
I just changed back Axios version in my project (0.19.0) and it's working fine.
Any idea why?
The text was updated successfully, but these errors were encountered: