Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes about finally #2593

Closed
chinesedfan opened this issue Dec 8, 2019 · 2 comments · Fixed by #2683
Closed

Revert changes about finally #2593

chinesedfan opened this issue Dec 8, 2019 · 2 comments · Fixed by #2683

Comments

@chinesedfan
Copy link
Collaborator

Section/Content To Improve
https://github.com/axios/axios/blob/master/README.md#note-commonjs-usage

Suggested Improvement
See #2305 (review). Revert #2189 and #2090.

Relevant File(s): README.md
@yasuf
Copy link
Collaborator

yasuf commented Dec 20, 2019

what do we need to do here? replace the .finally with then right? as a shim is needed for that to work

@chinesedfan
Copy link
Collaborator Author

replace the .finally with then right

@yasuf Yes, don't make users think every Promise implementation has a finally method already. It is still on draft stage. See MDN.

@chinesedfan chinesedfan mentioned this issue Jan 21, 2020
Merged
@axios axios locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert finally as then chinesedfan/axios
2 participants
@chinesedfan @yasuf