Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change syntax to see if build passes #2488

Merged
merged 5 commits into from Oct 25, 2019
Merged

Conversation

yasuf
Copy link
Collaborator

@yasuf yasuf commented Oct 24, 2019

Changes

  • Testing if build passes with this PR

@yasuf
Copy link
Collaborator Author

yasuf commented Oct 24, 2019

@felipewmartins do you have access to the travisCI instance? could you clear the cache of this latest build and rerun whenever you have a chance?

@yasuf
Copy link
Collaborator Author

yasuf commented Oct 24, 2019

nevermind, I upgraded the node version and now it passed, weird that my build didn't run Safari or Opera

@yasuf
Copy link
Collaborator Author

yasuf commented Oct 24, 2019

how can I enable my build to run on Sauce Labs ? cc @felipewmartins @emilyemorehouse

@yasuf
Copy link
Collaborator Author

yasuf commented Oct 25, 2019

can you test this change on your branch?

@yasuf
Copy link
Collaborator Author

yasuf commented Oct 25, 2019

I'm sort of blocked since I'm not able to run the build on Sauce Labs. When I add all the other browsers, the build fails but it's running the tests in Travis instead of Sauce Labs so I'm not sure if that's the problem.

@felipewmartins felipewmartins merged commit 494d817 into axios:master Oct 25, 2019
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants